HardFaultTrampoline now passes &mut ExceptionFrame #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to allow for a user provided HardFault handler to modify the exception frame (e.g. to return to a different PC) the signature for the function to be used with the `#[HardFault]` handler now has a `&mut ExceptionFrame` instead of just a reference.
|
This would be a Can the macro be adjusted to accept either a shared reference or a mutable reference as an argument to the handler function? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow for a user provided HardFault handler to modify the exception frame (e.g. to return to a different PC) the signature for the function to be used with the
#[HardFault]handler now has a&mut ExceptionFrameinstead of just a reference.Use case: we want to catch an exception, so we set some flag, run some code that might trigger a HardFault, update the flag in the handler, and return to the instruction after the one that caused the exception. We can then check the flag to see if an exception occurred or not. Key point is: to return to the instruction following the one that caused the exception, we want to modify the PC on the
ExceptionFramebefore loading EXC_RETURN onto the PC.