Skip to content

Commit

Permalink
Relax check-blobs check
Browse files Browse the repository at this point in the history
Turns out rustc has an unstable symbol order between Linux and macOS,
but only if `-Clinker-plugin-lto` is not used, so let's only check those
archives for binary changes for now.

Closes #329

Signed-off-by: Daniel Egger <daniel@eggers-club.de>
  • Loading branch information
therealprof committed Feb 9, 2021
1 parent 2281fd6 commit 42c8a5e
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions xtask/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ pub fn check_blobs() {
let mut files_before = BTreeMap::new();
for entry in fs::read_dir("bin").unwrap() {
let entry = entry.unwrap();
if entry.path().extension().unwrap() == "a" {
// Only check -lto.a files since those have the same symbol order between Linux and macOS
if entry.path().to_str().unwrap().ends_with("-lto.a") {
files_before.insert(
entry
.path()
Expand All @@ -178,7 +179,8 @@ pub fn check_blobs() {
let mut files_after = BTreeMap::new();
for entry in fs::read_dir("bin").unwrap() {
let entry = entry.unwrap();
if entry.path().extension().unwrap() == "a" {
// Only check -lto.a files since those have the same symbol order between Linux and macOS
if entry.path().to_str().unwrap().ends_with("-lto.a") {
files_after.insert(
entry
.path()
Expand Down

0 comments on commit 42c8a5e

Please sign in to comment.