Update rand to 0.7.0 #196
Update rand to 0.7.0 #196
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ithinuel (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Hi @timothyhollabaugh, there's already #195 which does the same thing. But there's a problem in |
|
I probably should've looked at the PRs before diving in... I can wait until #195 gets resolved. In the meantime, I suppose you can close this if you want. |
205: Stop using randomized symbol names r=therealprof a=jonas-schievink It isn't possible to do this by incrementing a global counter, since the expansion order of macros isn't guaranteed and might change between compiler invocations. Fixes #212 Closes #196 Closes #195 Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
205: Stop using randomized symbol names r=therealprof a=jonas-schievink It isn't possible to do this by incrementing a global counter, since the expansion order of macros isn't guaranteed and might change between compiler invocations. Fixes #212 Closes rust-embedded/cortex-m-rt#196 Closes rust-embedded/cortex-m-rt#195 Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
This updates the
randcrate to the latest version 0.7.0.I've been working on https://github.com/timothyhollabaugh/micromouse, which includes a cargo workspace with both a no_std bin crate for an stm32f4 (
firmware) and a std bin crate (simulation) for running on a normal computer. One of the dependencies insimulationdepends onrand0.6.5, andfirmwaredepends oncortex-m-rt-macroswhich depends onrand0.5.5. However, due to issue 645 in therandrepo, having both these versions ofrandwith one being no_std and one std in the dependency tree causes compile errors. Hence the upgrade to 0.7.0.Everything builds, and I have tested it with the uart isr in the above repo.