Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting window size in spawned process. #120

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kosayoda
Copy link
Contributor

@kosayoda kosayoda commented Apr 3, 2024

My use-case for this is for testing a shell that uses the rustyline crate for line-editing.
For long inputs (greater than the terminal width), rustyline inserts newlines into its output, which breaks tests using rexpect to match expected strings.
This PR would allow users to for example, set the terminal size to 200 columns wide, avoiding the aforementioned problem.
The feature is available in pexpect.

Coincidentally, this PR addresses the newly opened #119.

Draft Status

The PR is in draft because I am not sure what the best way to go about passing the Options is.
Currently it already feels weird to me propagating the reader::Options from spawn_with_options down the various containers to the NBReader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant