fix!: Replace atty with is_terminal #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is over 6 months old and allows us to hide optional dependencies as features so we can change them without breaking compatibility (after the first time).
This makes it easier to change dependencies in the future. BREAKING CHANGE: `termcolor` -> `color` and `atty` -> `auto-color`
g0hl1n
added a commit
to g0hl1n/mio-serial
that referenced
this pull request
Dec 13, 2022
This is needed as env_logger v0.10.0 raised its MSRV to 1.60.0. For more
information please see the corresponding commit or PR:
rust-cli/env_logger@660cf7f
rust-cli/env_logger#248
Signed-off-by: Richard Leitner <dev@g0hl1n.net>
g0hl1n
added a commit
to g0hl1n/mio-serial
that referenced
this pull request
Jan 13, 2023
This is needed as env_logger v0.10.0 raised its MSRV to 1.60.0. For more
information please see the corresponding commit or PR:
rust-cli/env_logger@660cf7f
rust-cli/env_logger#248
Signed-off-by: Richard Leitner <dev@g0hl1n.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to get around a soundness issue.
As part of this, the MSRV was bumped to 1.60
BREAKING CHANGES: Features renamed
termcolor->coloratty->auto-color