use target instead of module_path in formatter by default #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Target is used in filter, and its value defaults to module_path. To enable user customize the format, also to reduce confusion, makes formatter supporting target as well. This change introduces a boolean builder variable "honor_target". When set to true(the default), formatter will use target in the record metadata. Fix rust-cli#155 and rust-cli#179.
|
I'd love to have this feature, even if the default behaviour remains the same. |
|
Superseeded by #209. Thanks for opening a PR and sorry that I wasn't active to merge it earlier on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target is used in filter, and its value defaults to module_path. To
enable user customize the format, also to reduce confusion, makes
formatter supporting target as well.
This change introduces a boolean builder variable "honor_target". When
set to true(the default), formatter will use target in the record
metadata.
Fix #155 and #179.