Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test with -Z minimal-versions on CI #114

Merged
merged 2 commits into from Nov 8, 2018
Merged

Test with -Z minimal-versions on CI #114

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e54a7d
Test with `-Z minimal-versions` on CI
hcpl Nov 6, 2018
5d2434e
Address review suggestions
hcpl Nov 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .travis.yml
View file
Open in desktop
Expand Up @@ -10,6 +10,9 @@ before_script:
script:
- cargo run -p ci
- cargo run --example default
- if [ "${TRAVIS_RUST_VERSION}" = nightly ]; then cargo update -Z minimal-versions; fi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we run this as a separate travis environment that just does the -Z minimal-versions check at the start?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A separate travis job is fine, but what do you mean by "just the -Z minimal-versions check at the start"? Just cargo update -Z minimal-versions is not enough.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I meant switch on some environment variable instead of the nightly version. But the script is only a few lines so we could just duplicate the script in the travis environment specifically for testing minimal versions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, I'll try the switch one then.

- if [ "${TRAVIS_RUST_VERSION}" = nightly ]; then cargo run -p ci; fi
- if [ "${TRAVIS_RUST_VERSION}" = nightly ]; then cargo run --example default; fi
after_success:
- travis-cargo --only nightly doc-upload

Expand Down