Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ThirtyTwoByteHash #686

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Deprecate ThirtyTwoByteHash #686

merged 2 commits into from
Apr 2, 2024

Commits on Apr 2, 2024

  1. Fix import warnings 

    Recent rustc upgrade introduced some new warnings for incorrect imports,
fix them.
    @tcharding
    tcharding committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    88c8c58 View commit details
    Browse the repository at this point in the history

  2. Deprecate ThirtyTwoByteHash 

    The implementations of `ThirtyTwoByteHash` for types from the `hashes`
crate are problematic during upgrades because both `bitcoin` and
`secp256k1` depend on `hashes` and when the versions of `hashes` get
out of sync usage of the trait breaks.

Deprecate the `ThirtyTwoByteHash` trait and remove the impls for types
from `bitcoin_hashes`.

Add an explanation in the changelog because its too long to go in the
deprecation message.
    @tcharding
    tcharding committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    9f28cf6 View commit details
    Browse the repository at this point in the history