Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update vendored libsecp to 0.3.2 #645

Closed
wants to merge 8 commits into from
Closed

update vendored libsecp to 0.3.2 #645

wants to merge 8 commits into from

Commits on Aug 16, 2023

  1. gitignore: remove things that shouldn't be there 

    upstream libsecp now has a CMakeLists.txt file. Many years ago we added
some things to .gitignore which appear to be local developers committing
the names of their own stray files, and now this is causing the
revendoring script to lose track of vendored files.
    @apoelstra
    apoelstra committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    bebc7c0 View commit details
    Browse the repository at this point in the history

  2. lib: fix bad unit test

    @apoelstra
    apoelstra committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    99d129a View commit details
    Browse the repository at this point in the history

  3. delete test_manual_create_destroy test 

    This is just a bad test. It constructs a preallocated context object by
starting from a non-preallocated context object, in a way that can't be
done by users (since it directly constructs a `Secp256k1` struct) and a
way that is very difficult to unwind, because you wind up with two
pointers to the same underlying context object, one a "preallocated" one
and one a normal one.

If you then drop the preallocated one, it will call
`secp256k1_context_destroy`, forcing you to manually deallocate the
other one. If you drop the normally-allocated one, you need to
mem::forget the preallocated one to avoid calling
`secp256k1_context_destroy` twice. The whole thing is pretty fragile.

There is another unit test, `test_raw_ctx`, which gets into the same
situation but using the public API, and demonstrates a few ways to get
out of it.
    @apoelstra
    apoelstra committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    36339f2 View commit details
    Browse the repository at this point in the history

  4. secp256k1-sys: update patchfiles for upcoming update to libsecp

    @apoelstra
    apoelstra committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    1639f25 View commit details
    Browse the repository at this point in the history

  5. secp256k1-sys: delete .orig files 

    I'm not sure how these came to be committed, but they shouldn't be.
Running the vendoring script results in them being deleted.
    @apoelstra
    apoelstra committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    b8f7a16 View commit details
    Browse the repository at this point in the history

  6. secp256k1-sys: update vendored libsecp to v0.3.2 tag

    @apoelstra
    apoelstra committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    b09935d View commit details
    Browse the repository at this point in the history

  7. secp256k1-sys: bump version to 0.9.0 (but don't release yet)

    @apoelstra
    apoelstra committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    ac6d106 View commit details
    Browse the repository at this point in the history

  8. ci: generalize grp in "illegal callback" test

    @apoelstra
    apoelstra committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    186b643 View commit details
    Browse the repository at this point in the history