Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document sig verify's intentional limitation #592

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Document sig verify's intentional limitation #592

merged 1 commit into from
Mar 29, 2023

Conversation

TomMD
Copy link
Contributor

@TomMD TomMD commented Mar 29, 2023

This bit of documentation is similar to the secp256k1 C lib comment:

 * To avoid accepting malleable signatures, only ECDSA signatures in lower-S
 * form are accepted.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6e0ae2a

@apoelstra apoelstra merged commit 57a4dbc into rust-bitcoin:master Mar 29, 2023
25 of 26 checks passed
@apoelstra
Copy link
Member

apoelstra commented Mar 29, 2023

Oops, I should not have merged so quickly. Apparently we have doctests now that can detect broken links (and this link is broken).

@TomMD if you are around and willing to make a followup PR which changes the format of the normalize_s link?

The failure is here https://github.com/rust-bitcoin/rust-secp256k1/actions/runs/4556270336/jobs/8037091233?pr=592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants