Bump secp256k1-sys to v0.8.1 #590
Conversation
|
Please bump the patch version. Bumping the minor version is interpreted by Cargo as a breaking change. |
|
Oh because its pre-1.0? Post 1.0.0 an API addition requires bump of minor version, right? |
|
Oh bother, we have to fix symbol names too. |
Yes. |
tcharding
force-pushed
the
03-16-upgrade-secp-sys
branch
from
714d03b
to
35fd38d
Compare
FTR I'm not convinced bumping the patch version is correct here but I'm deferring to @apoelstra and @Kixunil on it. Will convince myself at a later time and date. |
We are ready to release a new minor version of `secp256k1-sys`, in order to do so we must make change the symbol names to reflect the new version as well as the usual changelog and version bump. In preparation for releasing `secp256k1-sys` v0.8.1 do: - Rename symbols to from `0_8_0` -> `0_8_1`, done mechanically (search and replace) - Add changes log notes (includes changelog entry for 0.8.0) - Bump `secp256k1-sys` crate version 0.8.0 -> 0.8.1, justified because we have added a new public function.
tcharding
force-pushed
the
03-16-upgrade-secp-sys
branch
from
35fd38d
to
5ae136d
Compare
|
Force pushed to remove changes to |
|
in interest of getting the release out, will ACK and mrerge this. But we should change our vendor-secp.sh file to avoid modifying the libsecp CHANGELOG. I have a couple other changes I want to make to that file, I'll PR separately. |
|
Tagged and published secp256k1-sys 0.8.1 and secp256k1 0.27.0 |
ffee8ad Bump version to v0.30.0 (Tobin C. Harding) Pull request description: Add changelog notes and bump the version number to v0.30.0. ## TODO - pre-merge - [x] Release `bitcoin_hashes` 0.12: #1694 - [x] Release secp 0.27: rust-bitcoin/rust-secp256k1#588 - rust-bitcoin/rust-secp256k1#590 - [x] Update `secp256k1` dependency to use newly released v0.27: #1714 - [x] Merge - ~#1696 - #1695 - #1111 - [x] If time permits merge these: - #1710 - #1705 - #1713 - [x] Set the release date in changelog header - [x] And merge these: - #1721 - #1720 - #1719 - #1717 ## TODO - post release - [ ] Release the blogpost: rust-bitcoin/www.rust-bitcoin.org#2 - ~Set the date in the blog post to match the date 0.30 is released~ ACKs for top commit: sanket1729: reACK ffee8ad Kixunil: ACK ffee8ad apoelstra: ACK ffee8ad Tree-SHA512: b0ea113ee1726fd9b263d0e01fe14bd544c007c05a9ac43b6c2d4edbeef3bb3ad456b061ef086626e1e1b27a0cda49cb6bc28aac3ad1691d72ffe00400ed5b45
We just bumped the version of
secp256k1, since we recently added a new public function tosecp256k1-syswe need to bump the minor version number there too.Should have been done as part of #588, its hard to get good help :)