Add additional changelog entry #557
Conversation
|
We never released 0.25.0 so we can just stick with that version number. |
|
Awesome, so I didn't have to change the report. :D |
|
@tcharding can you update this PR so it updates the changelog and does nothing else? |
tcharding
force-pushed
the
bump-0.25.1
branch
from
7632b59
to
a929f28
Compare
|
Done, thanks for catching my mistake. |
I hope patch 1 is ok, its in there so the backports and this all have exactly the same rustdoc code. |
As is customary add a newline between rustdoc heading and content. Done so that the code is identical to other released code (during backport the space was added).
tcharding
force-pushed
the
bump-0.25.1
branch
from
a929f28
to
40c56d5
Compare
|
I fixed the commit message since this repo does not require two acks @apoelstra will be able to merge it still with his ack. Thanks |
|
@tcharding this commit adds trailing whitespace at the top of the changelog file. |
|
Also sorry, we have to fix #562 before release. |
Recently we found and fixed an unsoundness issue in the `preallocated_gen_new` function. As we have yet to release 0.25.0 we can just update the changelog to reflect the newly merged fix.
tcharding
force-pushed
the
bump-0.25.1
branch
from
40c56d5
to
494b07a
Compare
Strange, I wonder why the githook didn't catch this? Even more strange I wonder why I push changes still to this day without reading the diff ... I definitely owe you a beer for this one. |
|
Lol, jeez. Since #551 we need to do a major rev of secp256k1-sys, and then we can release 0.25.0. |
|
Ah, #549 does this. But it needs a rebase. |
Bump version to 0.25.1 ready to releaseAdd changelog entry for the recently fixed unsoundness issue.Patch 1 is an annoyingly trivial fix to docs.