Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix soundness issue with preallocated_gen_new #548

Merged
merged 2 commits into from Dec 4, 2022
Merged

fix soundness issue with preallocated_gen_new #548

merged 2 commits into from Dec 4, 2022

Commits on Dec 2, 2022

  1. context: introduce unsafe PreallocatedContext trait 

    Fixes unsoundness in `preallocated_gen_new` which previously did not
properly constrain the lifetime of the buffer used to back the context
object. We introduce an unsafe marker trait, and impl it for our
existing preallocated-context markers.

Annoyingly the trait has to be public even though it should never be
used directly, and is only used alongside the sealed `Context` trait,
so it is de-facto sealed itself.

Fixes rust-bitcoin#543
    @apoelstra
    apoelstra committed Dec 2, 2022
    Copy the full SHA
    f961497 View commit details
    Browse the repository at this point in the history

  2. shut clippy up

    @apoelstra
    apoelstra committed Dec 2, 2022
    Copy the full SHA
    1e6eb6c View commit details
    Browse the repository at this point in the history