Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context: introduce alternate global context scheme based on #346 #539

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Commits on Nov 24, 2022

  1. Configuration menu
    Copy the full SHA
    a986e8d View commit details
    Browse the repository at this point in the history
  2. secp256k1-sys: make signing context pointers atomic

    This is in its own commit so that we can argue about it independently
    of the rest of the PR. I believe this is correct and safe because the
    docs for `AtomicPtr` say that (a) it is #[repr(C)] and (b) that it
    has the same in-memory representation as a *mut T.
    apoelstra committed Nov 24, 2022
    Configuration menu
    Copy the full SHA
    7d925f6 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. context: add methods to provide immutable access and rerandomization

    This covers both the std and no-std cases. This is perhaps an unconventional
    strategy; see rust-bitcoin#346 for
    discussion leading up to it.
    apoelstra committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    a62f398 View commit details
    Browse the repository at this point in the history
  2. add a simple end-to-end test not feature-gated on std or alloc

    Weirdly we have no tests that don't require std or alloc. We should
    revisit this. In many cases it is because of the dependency on
    rand-std but we should really try to narrow that down to specific
    tests.
    apoelstra committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    a03bedd View commit details
    Browse the repository at this point in the history
  3. f try using the new global context

    This commit should probably be removed before merging; it can be part
    of the next PR.
    apoelstra committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    eac1b86 View commit details
    Browse the repository at this point in the history
  4. make cargo fmt shut up

    apoelstra committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    087c2f5 View commit details
    Browse the repository at this point in the history