Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secp-sys: change symbol names to 0_6_1 from 0_5_0 #490

Merged
merged 1 commit into from Oct 12, 2022

Conversation

apoelstra
Copy link
Member

Needed to build secp-sys 0.5 and secp-sys 0.6 in the same tree. Fixes #489.

This PR can be reproduced by running

./vendor-libsecp.sh depend/ 0_6_1 a1102b12196ea27f44d6201de4d25926a2ae9640

in the secp256k1-sys directory.

Needed to build secp-sys 0.5 and secp-sys 0.6 in the same tree. Fixes rust-bitcoin#489.

This PR can be reproduced by running

    ./vendor-libsecp.sh depend/ 0_6_1 a1102b1

in the secp256k1-sys directory.
Copy link
Member

@elichai elichai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK 91f1096
Reproduced the same diff locally

@apoelstra apoelstra merged commit 5e1e012 into rust-bitcoin:master Oct 12, 2022
@apoelstra apoelstra deleted the 2022-10--sys-061 branch October 12, 2022 15:32
@apoelstra
Copy link
Member Author

Published. Checked that rust-bitcoin still builds and I didn't somehow break it.

@apoelstra
Copy link
Member Author

Not going to bother yanking 0.6.0. It's not actually harmful for people to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build secp-sys 0.5 and 0.6 in same tree
2 participants