move some unsafe code inside an unsafe{} boundary #483
Conversation
|
Not sure if this is as tight as you were hoping for @Kixunil |
|
Interesting. I saw that clippy failure but ignored it since it had nothing to do with my code ... I guess it's a change in clippy and we need to fix it for CI to pass. |
|
I don't think it was a change in clippy because we use |
| let noncedata_ptr = match noncedata { | ||
| Some(arr) => arr.as_c_ptr() as *const _, | ||
| None => ptr::null(), | ||
| }; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Now I'm confused, I did a clippy PR #484 that includes additional fixes to this PR but this is green? And how is it green if the clippy fixes are done as second patch? |
|
CI only runs on the top commit -- and the top commit of this PR has the clippy fixes. |
An internal function had a non-unsafe signature but could be called with data that would cause it to exhibit UB. Move the unsafety inside of the function so that the function signature now enforces soundness. Fixes rust-bitcoin#481
apoelstra
force-pushed
the
2022-08--cleanup-noncedata-pointer
branch
from
29ce1cc
to
0f29348
Compare
|
Merged #484 and rebased. Now there are no clippy fixes in this PR. |
|
Merged -- the one remaining commit was identical to the one ACKed by Sanket and Kixunil, and while elichai did not specify a commit, there is really only one that was ever in this PR. |
Oh I'm a goose. |
An internal function had a non-unsafe signature but could be called
with data that would cause it to exhibit UB. Move the unsafety inside
of the function so that the function signature now enforces soundness.
Fixes #481