Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable re-randomization under more conditions #474

Merged
merged 3 commits into from Jul 19, 2022
Merged

Disable re-randomization under more conditions #474

merged 3 commits into from Jul 19, 2022

Commits on Jul 14, 2022

  1. apply global-context-not-secure logic to Secp256k1::new 

    Disable auto-rerandomization for both global and local contexts.
    @apoelstra
    apoelstra committed Jul 14, 2022
    Copy the full SHA
    7482846 View commit details
    Browse the repository at this point in the history

  2. context: unconditionally disable auto-rerandomization on wasm 

    This causes panics. We can't add catch the panic, we can't change its output, we
can't detect if it'll happen, etc. Rather than dealing with confused bug reports
let's just drop this.

If users want to rerandomize their contexts they can do so manually.

There is probably a better solution to this but it is still under debate, even
upstream in the C library, what this should look like. Meanwhile we have bug
reports now.
    @apoelstra
    apoelstra committed Jul 14, 2022
    Copy the full SHA
    b01337c View commit details
    Browse the repository at this point in the history

  3. bump version to 0.23.4

    @apoelstra
    apoelstra committed Jul 14, 2022
    Copy the full SHA
    d206891 View commit details
    Browse the repository at this point in the history