Derive Hash for ecdsa::Signature and SerializedSignature #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I see the reason it was not derived before: it requires MSRV version bump. Converting into draft for now |
|
Sorry man, I did not see this PR when I did #433. In 433 I did not derive |
elichai
reviewed
May 11, 2022
| pub struct Signature(pub(crate) ffi::Signature); | ||
|
|
||
| /// A DER serialized Signature | ||
| #[derive(Copy, Clone)] | ||
| #[derive(Copy, Clone, Hash)] |
There was a problem hiding this comment.
This will make it incompatible with the PartialEq, Eq traits, violating the required properties,
because data could somehow have arbitrary data after the len argument.
So I think we should implement Hash here manually
|
No, |
|
Superseded by #441 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hash trait is derived for
schnorr::Signature, but notecdsa::Signature. This prevents derivation ofHashon types downstream inrust-bitcoin, for instance Psbt-related types.