Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate schnorrsig #411

Merged
merged 4 commits into from Mar 4, 2022
Merged

Deprecate schnorrsig #411

merged 4 commits into from Mar 4, 2022

Commits on Mar 4, 2022

  1. Deprecate SCHNORRSIG_PUBLIC_KEY_SIZE 

    Recently we moved from using the identifier 'schnorrsig' to 'schnorr',
we omitted to update the schnorr public key size constant.

Deprecate `SCHNORRSIG_PUBLIC_KEY_SIZE` and add
`SCHONORR_PUBLIC_KEY_SIZE`.
    @tcharding
    tcharding committed Mar 4, 2022
    Copy the full SHA
    7a417fd View commit details
    Browse the repository at this point in the history

  2. Deprecate SCHNORRSIG_SIGNATURE_SIZE 

    Recently we moved from using the identifier 'schnorrsig' to 'schnorr',
we omitted to update the schnorr signature size constant.

Deprecate `SCHNORRSIG_SIGNATURE_SIZE` and add
`SCHONORR_SIGNATURE_SIZE`.
    @tcharding
    tcharding committed Mar 4, 2022
    Copy the full SHA
    79770e1 View commit details
    Browse the repository at this point in the history

  3. Remove schnorrsig from helper method 

    Recently we moved from using the identifier 'schnorrsig' to 'schnorr',
we omitted to update a helper function.
    @tcharding
    tcharding committed Mar 4, 2022
    Copy the full SHA
    4b840ff View commit details
    Browse the repository at this point in the history

  4. Remove schnorrsig from test names 

    Recently we moved from using the identifier 'schnorrsig' to 'schnorr',
we omitted to update the tests.

While we are at it use more idiomatic Rust unit test names (i.e., do not
start test name with `test_` because it stutters when the name is read
in output of `cargo test`).
    @tcharding
    tcharding committed Mar 4, 2022
    Copy the full SHA
    7b91f9d View commit details
    Browse the repository at this point in the history