-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.21.0 #347
Release 0.21.0 #347
Conversation
This breaks a lot of things downstream. I think it might a good idea to highlight a few of those in release notes.
Should I add a PR making these non-breaking changes? |
@sanket1729 you mean, PR to modify the changelog? I can do it. |
@apoelstra , see #348 . Would be great to have that in because downstream libs rust-bitcoin raise many compile errors. |
Great idea @sanket1729. Merged. |
utACK 8cfd26a |
ACK 8cfd26a Checked the changelog against the git log |
I'd like to get #344 in first actually, it's an API-breaking change but a very minor one. |
8cfd26a
to
c3df9b8
Compare
Rebased and added note to changelog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK c3df9b8. Excited for the new release
@elichai can I get a quick re-ACK and then I'll do it? |
re-ACK c3df9b8 |
Might also need a point release for rust-secp. See #360 |
Should have tested with rust-bitcoin before ACKing |
Lol oops. I had also wanted to get #353 in (though less critically). We'll do a point release. |
.