Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.21.0 #347

Merged
merged 1 commit into from Jan 5, 2022
Merged

Conversation

apoelstra
Copy link
Member

@apoelstra apoelstra commented Jan 2, 2022

.

@sanket1729
Copy link
Member

sanket1729 commented Jan 3, 2022

This breaks a lot of things downstream. I think it might a good idea to highlight a few of those in release notes.
Renamed:

  1. Moved schnorrsig module to schnorr
  2. Moved schnorrsig::PublicKey to XOnlyPublicKey
  3. Moved recovery to ecdsa::recovery.

Should I add a PR making these non-breaking changes?

@apoelstra
Copy link
Member Author

@sanket1729 you mean, PR to modify the changelog? I can do it.

@sanket1729
Copy link
Member

sanket1729 commented Jan 3, 2022

@apoelstra , see #348 . Would be great to have that in because downstream libs rust-bitcoin raise many compile errors.

@apoelstra
Copy link
Member Author

Great idea @sanket1729. Merged.

@sanket1729
Copy link
Member

utACK 8cfd26a

@elichai
Copy link
Member

elichai commented Jan 4, 2022

ACK 8cfd26a Checked the changelog against the git log

@apoelstra
Copy link
Member Author

I'd like to get #344 in first actually, it's an API-breaking change but a very minor one.

@apoelstra
Copy link
Member Author

Rebased and added note to changelog.

Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK c3df9b8. Excited for the new release

@apoelstra
Copy link
Member Author

@elichai can I get a quick re-ACK and then I'll do it?

@elichai
Copy link
Member

elichai commented Jan 5, 2022

re-ACK c3df9b8

@apoelstra apoelstra merged commit 11ef535 into rust-bitcoin:master Jan 5, 2022
@apoelstra apoelstra deleted the 2022-01--release-0.21 branch January 5, 2022 15:53
@apoelstra
Copy link
Member Author

Merged. Published.

Need to push new point release of secp256k1-sys because of #345 ... and actually I think #345 is missing a pub qualifier :)

@sanket1729
Copy link
Member

Might also need a point release for rust-secp. See #360

@sanket1729
Copy link
Member

utACK c3df9b8. Excited for the new release

Should have tested with rust-bitcoin before ACKing

@apoelstra
Copy link
Member Author

Lol oops. I had also wanted to get #353 in (though less critically). We'll do a point release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants