Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dangerous cargo features with rustc flags #263

Merged
merged 3 commits into from Dec 22, 2020
Merged

Replace dangerous cargo features with rustc flags #263

merged 3 commits into from Dec 22, 2020

Commits on Dec 22, 2020

  1. replace cargo external-symbols feature with a rustc --cfg flag 

    This feature was not useful for Cargo users, since Cargo does not give you
the kind of fine-grained control over C library linkage that you need. So
it was just unnecessarily confusing and would cause the build to break if
you enabled it accidentally, say, with --all-features.
    @apoelstra
    apoelstra committed Dec 22, 2020
    Copy the full SHA
    d77483f View commit details
    Browse the repository at this point in the history

  2. replace fuzztarget Cargo feature with a rustc --cfg flag 

    It's super dangerous to use Cargo features for this, since they can be set
accidentally (or maliciously by any crate in a user's entire dep tree). Instead
we can just require users set `RUSTFLAGS` appropriately, which we can easily
do in our fuzzing scripts.
    @apoelstra
    apoelstra committed Dec 22, 2020
    Copy the full SHA
    85075a6 View commit details
    Browse the repository at this point in the history

  3. add warning about fuzzing being enabled

    @apoelstra
    apoelstra committed Dec 22, 2020
    Copy the full SHA
    29316ef View commit details
    Browse the repository at this point in the history