Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update libsecp, remove endomorphism feature flag and release 0.20.0 #257

Merged
merged 6 commits into from Jan 3, 2021

Conversation

apoelstra
Copy link
Member

No description provided.

@apoelstra apoelstra force-pushed the 2020-12--no-endo branch 2 times, most recently from 83663db to 833b176 Compare December 28, 2020 19:58
sgeisler
sgeisler previously approved these changes Dec 29, 2020
Copy link
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 833b176

To review 8c74e53 I just ran the vendoring script and checked for a diff.

@dr-orlovsky
Copy link
Contributor

This looks like an important and trivial bugfix which may get merged before this release: #266

@elichai
Copy link
Member

elichai commented Dec 29, 2020

Can you also remove the endianess checks? they aren't needed anymore bitcoin-core/secp256k1#787

elichai
elichai previously approved these changes Dec 29, 2020
Copy link
Member

@elichai elichai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK
I tested rm -rf /depend/secp256k1 and ./vendor-libsecp.sh depend 0_4_0 master to make sure the results match,

@apoelstra apoelstra dismissed stale reviews from elichai and sgeisler via 585d43d December 29, 2020 17:16
@apoelstra apoelstra force-pushed the 2020-12--no-endo branch 2 times, most recently from 585d43d to 8511ec0 Compare December 29, 2020 19:30
Copy link
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK c4d2fef

Copy link
Member

@elichai elichai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK, ran the vendoring script on my machine and it produced the same result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants