Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature to disable replacing C symbols with rust #177

Merged
merged 2 commits into from Oct 29, 2019

Conversation

elichai
Copy link
Member

@elichai elichai commented Oct 28, 2019

Hi,
Requested in IRC by @TheBlueMatt the main use case is bitcoin core integration.
such that you can use upstream's libsecp256k1 with this library.

this feature is not compatible with no-std.

@apoelstra
Copy link
Member

Can you put a // Do not use this feature! or something warning that this is a bad/unsupported thing and we are only doing it for Core's sake, because Core shares developers with both this project and upstream libsecp?

@elichai
Copy link
Member Author

elichai commented Oct 28, 2019

Done. took the liberty and added that warning to fuzztarget too.
(FYI #154 )

@TheBlueMatt
Copy link
Member

ACK. This 176 appears to fully solve my issues linking into Core with its libsecp.

@apoelstra
Copy link
Member

I like the comment. Matt's ACK is good enough for me.

@apoelstra apoelstra merged commit d900dcd into rust-bitcoin:master Oct 29, 2019
@stevenroose
Copy link
Contributor

@elichai @TheBlueMatt so are you saying that you are using the C symbols exported by rust-secp? I don't think that's what this crate is supposed for, is it?

Doing that would also stop working with #169, which arguably makes this crate more interoperable with other systems.

@stevenroose
Copy link
Contributor

Oh I think I understood it wrong. You're using this library with the libsecp symbols already exported in Core?

That already makes more sense to me, but I think that will still be hard to make work with #169.

@elichai elichai deleted the 2019-10-csymbols branch October 29, 2019 10:02
@TheBlueMatt
Copy link
Member

TheBlueMatt commented Oct 29, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants