WIP: Demonstrate the new timelock APIs #446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on rust-bitcoin commit: `5d061776 Merge rust-bitcoin/rust-bitcoin#1076: Introduce SPDX license identifiers`
We are currently working on two new timelock APIs - `LockTime`: rust-bitcoin/rust-bitcoin#994 - `Sequence`: rust-bitcoin/rust-bitcoin#1093 This PR demonstrates how we would use those APIs here in miniscript. Includes improvements that are not yet in 1093. To test this out locally you can grab the `WIP-sequence-and-lock-time` branch from my tree. You'll have to have `rust-bitcoincore-rpc` locally and patch it to use local `rust-bitcoin`. This PR is not intended as a merge candidate.
This was referenced Jul 13, 2022
|
This demo is done now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently working on two new timelock APIs
LockTime: Add aLockTimetype rust-bitcoin#994Sequence: Add new type for sequence rust-bitcoin#1093This PR demonstrates how we would use those APIs here in miniscript.
Includes improvements that are not yet in 1093. To test this out locally
you can grab the
WIP-sequence-and-lock-timebranch from my tree.You'll have to have
rust-bitcoincore-rpclocally and patch it to uselocal
rust-bitcoin.This PR is not intended as a merge candidate, it will not pass CI because it uses local paths for
rust-bitcoindependency.