Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in absolute timelock usage #419

Merged
merged 3 commits into from Jun 2, 2022

Commits on May 25, 2022

  1. Fix incorrect timelock docs

    We have mixed up relative/absolute on the trait methods for `from_after`
    and `from_older`.
    tcharding committed May 25, 2022
    Configuration menu
    Copy the full SHA
    0b62f5e View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. Add a minimal timelock module

    Currently if we mix up height/time absolute timelocks when filtering
    policies the result is incorrect.
    
    Add a `timelock` module that includes a single public function for
    checking if absolute timelocks are the same unit. Use the new function
    to fix a bug in policy filtering.
    tcharding committed May 26, 2022
    Configuration menu
    Copy the full SHA
    e4eb285 View commit details
    Browse the repository at this point in the history
  2. Unit test mixed up absolute timelocks

    Currently if we mix up height/time absolute timelocks when filtering
    policies the result is incorrect.
    
    Add a bunch of assertions that verify the bug.
    tcharding committed May 26, 2022
    Configuration menu
    Copy the full SHA
    42e1216 View commit details
    Browse the repository at this point in the history