Skip to content

Commit

Permalink
Merge #89: Remove SECP256K1_BUILD
Browse files Browse the repository at this point in the history
ff73635 Remove SECP256K1_BUILD (Tobin C. Harding)

Pull request description:

  Setting this variable causes a build warning, removing it doesn't seem to break anything and removes the warning. Also we do not set this variable when building `secp256k1-sys` over in the secp crate.

  I have no idea what the variable was intended to do though.

ACKs for top commit:
  apoelstra:
    ACK ff73635

Tree-SHA512: 21e5c000726413c1d8755c4910676204a4fd8109cc33a64cb297b85c1b558b25de6db29da1a4e437c8365fae717adbb25ac9deac5c380c47c625015667772dd5
  • Loading branch information
apoelstra committed Feb 4, 2024
2 parents c8f244f + ff73635 commit d44e624
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ fn main() {
.include("depend/bitcoin/src/secp256k1")
.include("depend/bitcoin/src/secp256k1/src")
.flag_if_supported("-Wno-unused-function") // some ecmult stuff is defined but not used upstream
.define("SECP256K1_BUILD", "1")
// Bitcoin core defines libsecp to *not* use libgmp.
.define("USE_NUM_NONE", "1")
.define("USE_FIELD_INV_BUILTIN", "1")
Expand Down

0 comments on commit d44e624

Please sign in to comment.