Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Serde's default-features #905

Merged
merged 3 commits into from Apr 30, 2022
Merged

Disable Serde's default-features #905

merged 3 commits into from Apr 30, 2022

Commits on Apr 25, 2022

  1. Disable Serde's default-features 

    We do not need serde/std, only serde/alloc. Serde/std breaks no-std
builds, but serde/alloc does not. Depending on serde/alloc is the more
compatible approach, as the entire library already depends on alloc.
    ass3rt committed Apr 25, 2022
    Copy the full SHA
    7db03f2 View commit details
    Browse the repository at this point in the history

  2. Removed reimplementations of default methods 

    The default methods do the exact same thing thus our overrides are
useless, potentially even problematic.

Credit to Kixunil for this fix: rust-bitcoin#905 (comment)
    ass3rt committed Apr 25, 2022
    Copy the full SHA
    add100c View commit details
    Browse the repository at this point in the history

  3. Override default visit_byte_buf on Script 

    This override may avoid allocation and thus make the deserialization
faster.

Credit to Kixunil for this fix: rust-bitcoin#905 (comment)
    ass3rt committed Apr 25, 2022
    Copy the full SHA
    76fcf81 View commit details
    Browse the repository at this point in the history