Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infallible conversions from hashes to secp256k1 message #851

Conversation

kafaichoi
Copy link
Contributor

@kafaichoi kafaichoi commented Feb 26, 2022

Close 824

Updated
The CI will be fixed after updating to new secp256k1 version including this change rust-bitcoin/rust-secp256k1#410

@apoelstra
Copy link
Member

There are two issues here:

  1. Our CI is broken because of some honggfuzz issue. This should be fixed now as I just merged Tempararily pin fuzzer on rust 1.58 #848
  2. There is some issue with the bitcoin_hashes feature, which I haven't understood yet. But we should fix this, there's no reason rust-bitcoin shouldn't have this feature turned on.

@kafaichoi kafaichoi marked this pull request as draft February 27, 2022 02:25
@kafaichoi kafaichoi force-pushed the infallible-conversions-from-hashes-to-secp256k1-messages branch from c1c6cc1 to 03a0b26 Compare February 27, 2022 02:26
@kafaichoi
Copy link
Contributor Author

There are two issues here:

1. Our CI is broken because of some honggfuzz issue. This should be fixed now as I just merged [Tempararily pin fuzzer on rust 1.58 #848](https://github.com/rust-bitcoin/rust-bitcoin/pull/848)

2. There is some issue with the `bitcoin_hashes` feature, which I haven't understood yet. But we should fix this, there's no reason rust-bitcoin shouldn't have this feature turned on.

As u said, first issue is resolved after rebasing latest master. For the issue 2, it looks like it's related to no std. I am looking into this🙏🏽(Changed PR status to draft)

@tcharding
Copy link
Member

For your reference, the CI failure has an open issue.

@kafaichoi
Copy link
Contributor Author

For your reference, the CI failure has an open issue.

Yes I think the issue should be related to bitcoin_cash default-features is enabled in rust-secp256k1. I get the ci pipeline working by adding default-features = false in forked rust-secp

Related commits in my forked ones

rust-bitcoin kafaichoi@19d1bfa
related github action https://github.com/bruteforcecat/rust-bitcoin/actions/runs/1908337297
rust-secp256k1 kafaichoi/rust-secp256k1@e3af344

@apoelstra
Copy link
Member

Looks like this was fixed by #1118

@apoelstra apoelstra closed this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use infallible conversions from hashes to secp256k1::Message
3 participants