Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.27.0 #631

Merged
merged 1 commit into from Jul 21, 2021
Merged

Bump version to 0.27.0 #631

merged 1 commit into from Jul 21, 2021

Conversation

RCasatta
Copy link
Collaborator

The minor version increment is due to the breaking changes in #601 and #521

@Kixunil
Copy link
Collaborator

Kixunil commented Jul 21, 2021

I just noticed this TODO

Maybe it should be addressed?

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Kixunil good catch. I think this can wait for the next major release (Taproot support) which shouldn't be too much longer. I'd like to get this one out ASAP because it's blocking some embedded users.

Copy link
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK ef69f24

Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACk ef69f24 . Tested that this does not break anything(unexpected) for rust-miniscript downstream.

@sanket1729
Copy link
Member

sanket1729 commented Jul 21, 2021

Before we tag a release, I think we should check that this does not break anything expected for a few major projects(BDK, rust-lightning). This is to avoid issues like #608
This is a major version change, so it's not a big deal. But still good to check

@sgeisler
Copy link
Contributor

sgeisler commented Jul 21, 2021

I verified that BDK builds and has no test failures with current master (without version bump commit). To build with 0.27 at least our bitcoincore-rpc crate would need a version bump too afaik.

I used the following diff with ../rust-bitcoin being at df4d70a and BDK at v0.9.0 (commit bitcoindevkit/bdk@4e813e8).

diff --git a/Cargo.toml b/Cargo.toml
index 6d5493a..aabfe70 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -92,3 +92,6 @@ members = ["macros"]
 features = ["compiler", "electrum", "esplora", "compact_filters", "rpc", "key-value-db", "all-keys", "verify"]
 # defines the configuration attribute `docsrs`
 rustdoc-args = ["--cfg", "docsrs"]
+
+[patch.crates-io]
+bitcoin = { path = "../rust-bitcoin" }

@romanz
Copy link
Contributor

romanz commented Jul 21, 2021

Tested ACK for electrs :)

@apoelstra
Copy link
Member

Thanks!

@Kixunil
Copy link
Collaborator

Kixunil commented Jul 21, 2021

Loptos also works. :)

@apoelstra
Copy link
Member

Sounds like we're good to go :)

@RCasatta
Copy link
Collaborator Author

RCasatta commented Aug 6, 2021

#640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants