New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 0.27.0 #631
Conversation
I just noticed this TODO Maybe it should be addressed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
@Kixunil good catch. I think this can wait for the next major release (Taproot support) which shouldn't be too much longer. I'd like to get this one out ASAP because it's blocking some embedded users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK ef69f24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACk ef69f24 . Tested that this does not break anything(unexpected) for rust-miniscript
downstream.
Before we tag a release, I think we should check that this does not break anything expected for a few major projects(BDK, rust-lightning). This is to avoid issues like #608 |
I verified that BDK builds and has no test failures with current master (without version bump commit). To build with 0.27 at least our bitcoincore-rpc crate would need a version bump too afaik. I used the following diff with diff --git a/Cargo.toml b/Cargo.toml
index 6d5493a..aabfe70 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -92,3 +92,6 @@ members = ["macros"]
features = ["compiler", "electrum", "esplora", "compact_filters", "rpc", "key-value-db", "all-keys", "verify"]
# defines the configuration attribute `docsrs`
rustdoc-args = ["--cfg", "docsrs"]
+
+[patch.crates-io]
+bitcoin = { path = "../rust-bitcoin" } |
Tested ACK for |
Thanks! |
Loptos also works. :) |
Sounds like we're good to go :) |
The minor version increment is due to the breaking changes in #601 and #521