-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Taproot BIP341 signature message and create a unified sighash cache for legacy, segwit and taproot inputs #628
Merged
Merged
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
683b9c1
add [En|De]codable trait for sha256::Hash
RCasatta 24acfe3
Implement Bip341 signature hash, create unified SigHashCache for tapr…
RCasatta 15e3caf
[test] Test also sighash legacy API with legacy tests
RCasatta 53d0e17
Deprecate bip143::SigHashCache in favor of sighash::SigHashCache
RCasatta 1a7afed
Add Reserved variant to SigHashType for future use (ie SIGHASH_ANYPRE…
RCasatta 2b3b22f
impl Encodable for Annex to avoid allocation
RCasatta 55ce3dd
Fix validation error if SINGLE with missing corresponding output, rem…
RCasatta 417cfe3
Derive common traits for structs and enum, make internal struct not pub
RCasatta 1a2b54f
introduce constant KEY_VERSION_0
RCasatta 6e06a32
Wrap ErrorKind in Io enum variant, fix doc comment for the IO variant
RCasatta ca80a5a
Use get_or_insert_with in taproot_cache
Kixunil 497dbfb
Use get_or_insert_with in common_cache()
Kixunil 0777491
Use get_or_insert_with in segwit_cache
Kixunil c9bc0b9
[fmt-only] autoformatting with `rustfmt src/util/sighash.rs`
RCasatta f223be6
Rename access_witness to witness_mut and return Option
RCasatta c704ee7
[docs-only] Use backtick in addition to square parentheses for types …
RCasatta File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit (please don't change): after #603 this is not entirely correct anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in c704ee7 (Since other changes were needed)