Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Amount type in verify #621

Merged
merged 1 commit into from Aug 9, 2021

Conversation

RCasatta
Copy link
Collaborator

In #598 verify function signature has left untouched to avoid breaking the API

This address #598 (comment) but it's a breaking change

Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK a86bced

Copy link
Collaborator

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, I should really rebase my other PR about this 😅

@sgeisler sgeisler added the API break This PR requires a version bump for the next release label Jun 23, 2021
@dr-orlovsky
Copy link
Collaborator

Merging, since the PR meets all requirements and was pending just for a major API-breaking release

@dr-orlovsky dr-orlovsky merged commit 33393e0 into rust-bitcoin:master Aug 9, 2021
@dr-orlovsky dr-orlovsky added this to the 0.28.0 milestone Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API break This PR requires a version bump for the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants