Implement taproot specific script helpers #604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrawsthorne
force-pushed
the
taproot_script
branch
from
e9e47be
to
c805ff4
Compare
|
There is also a dependency on #585 imo. |
dr-orlovsky
reviewed
May 18, 2021
src/blockdata/script.rs
Outdated
| @@ -271,6 +272,11 @@ impl Script { | |||
| Script::new_witness_program(::bech32::u5::try_from_u8(0).unwrap(), &script_hash.to_vec()) | |||
| } | |||
|
|
|||
| /// Generates P2TR-type of scriptPubkey | |||
| pub fn new_v1_tr(public_key: &schnorr::PublicKey) -> Script { | |||
| Script::new_witness_program(::bech32::u5::try_from_u8(1).unwrap(), &public_key.serialize().to_vec()) | |||
There was a problem hiding this comment.
Not sure why you are calling allocating to_vec() function just to take the reference after.
Also will need to get rid out of u5-caused unwrap, but that requires #563 merge as you said, with its WitnessVersion type
There was a problem hiding this comment.
You're right. I've removed that and added a commit to do the same for new_v0_wpkh() and new_v0_wsh()
Comment on lines
+408
to
+409
| self.0[0] == opcodes::all::OP_PUSHNUM_1.into_u8() && | ||
| self.0[1] == opcodes::all::OP_PUSHBYTES_32.into_u8() |
There was a problem hiding this comment.
Not related to the PR, but just a thought that we probably need to refactor all these opcode-based version guessing via WitnessVersion API
jrawsthorne
force-pushed
the
taproot_script
branch
from
c805ff4
to
ca90a6c
Compare
|
Am I right that this PR was superseded by #585? |
|
ping @jrawsthorne |
|
This is now done as a part of #696. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the script parts of #503. Will rebase with changes from #563 once it's merged