Constructors for compressed and uncompressed ECDSA keys #592
Conversation
src/util/key.rs
Outdated
| @@ -78,6 +78,23 @@ pub struct PublicKey { | |||
| } | |||
|
|
|||
| impl PublicKey { | |||
| /// Constructs compressed ECDSA PublicKey from the provided generic Secp256k1 public key | |||
| pub fn compressed(pk: secp256k1::PublicKey) -> PublicKey { | |||
There was a problem hiding this comment.
I would prefer just new for a compressed key (same for private)
There was a problem hiding this comment.
Agree. May be also legacy for uncompressed?
There was a problem hiding this comment.
For uncompressed I personally haven't a preference both uncompressed or legacy are ok
There was a problem hiding this comment.
I'd prefer new and new_uncompressed
|
@apoelstra done |
There was a problem hiding this comment.
@dr-orlovsky, I think you probably forgot to push the changes 😛
|
@sanket1729 yeah, also needed rebase baeause of #589 merge |
src/util/ecdsa.rs
Outdated
| @@ -37,6 +37,23 @@ pub struct PublicKey { | |||
| } | |||
|
|
|||
| impl PublicKey { | |||
| /// Constructs compressed ECDSA PublicKey from the provided generic Secp256k1 public key | |||
There was a problem hiding this comment.
Very minor nit: if it's not code, i.e. a type, I wouldn't write public key in camel case. If it's code/a type it should be formatted as such.
src/util/ecdsa.rs
Outdated
| pub fn new(pk: secp256k1::PublicKey) -> PublicKey { | ||
| PublicKey { | ||
| compressed: true, | ||
| key: pk, |
There was a problem hiding this comment.
Minor nit, pk could be renamed to key which would allow to write key, instead of key: pk,.
|
@sgeisler I checked the library, updated all places (including tests and docs) where the new API can be used. Next, as a separate commit 187eae8 I added |
No description provided.