New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix warnings for sighashtype #586
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 3545580
EDIT:
tACK 3545580
Test log:
Apr 08 14:41:24.196 INFO testinator: Installing rust toolchain 'nightly'
Apr 08 14:41:28.014 INFO testinator: Installing rust toolchain 'stable'
Apr 08 14:41:28.685 INFO testinator: Installing rust toolchain '1.29.0'
Apr 08 14:41:29.749 INFO testinator: Preparing environment for rust stable tests (8 configurations)
Apr 08 14:41:29.749 INFO testinator: Preparing environment for rust 1.29.0 tests (8 configurations)
Apr 08 14:41:29.749 INFO testinator: Preparing environment for rust nightly tests (9 configurations)
Apr 08 14:44:19.251 INFO testinator: Running rust 1.29.0 tests in /tmp/rust-bitcoin-1.29.0.NLM69DVefjE9/rust-bitcoin
Apr 08 14:44:19.251 DEBUG testinator: Generating lock file with rust=1.29.0
Apr 08 14:44:19.256 INFO testinator: Running rust nightly tests in /tmp/rust-bitcoin-nightly.1A05Uy9TBX8a/rust-bitcoin
Apr 08 14:44:19.259 INFO testinator: Running rust stable tests in /tmp/rust-bitcoin-stable.D3rlhzXE6535/rust-bitcoin
Apr 08 14:44:22.254 DEBUG testinator: Pinning cc to 1.0.41
Apr 08 14:44:22.400 DEBUG testinator: Pinning serde to 1.0.98
Apr 08 14:44:22.535 DEBUG testinator: Pinning serde_derive to 1.0.98
Apr 08 14:44:22.675 DEBUG testinator: Pinning byteorder to 1.3.4
Apr 08 14:45:06.678 INFO testinator: Test rust=nightly, features=[secp-recovery] succeeded!
Apr 08 14:45:13.958 INFO testinator: Test rust=stable, features=[secp-recovery] succeeded!
Apr 08 14:45:56.807 INFO testinator: Test rust=nightly, features=[use-serde] succeeded!
Apr 08 14:46:03.283 INFO testinator: Test rust=1.29.0, features=[secp-recovery] succeeded!
Apr 08 14:46:19.574 INFO testinator: Test rust=stable, features=[use-serde] succeeded!
Apr 08 14:46:23.462 INFO testinator: Test rust=nightly, features=[base64] succeeded!
Apr 08 14:46:50.785 INFO testinator: Test rust=stable, features=[base64] succeeded!
Apr 08 14:47:06.062 INFO testinator: Test rust=nightly, features=[secp-lowmemory] succeeded!
Apr 08 14:47:25.416 INFO testinator: Test rust=stable, features=[secp-lowmemory] succeeded!
Apr 08 14:47:35.702 INFO testinator: Test rust=nightly, features=[rand] succeeded!
Apr 08 14:47:57.957 INFO testinator: Test rust=1.29.0, features=[use-serde] succeeded!
Apr 08 14:47:58.183 INFO testinator: Test rust=stable, features=[rand] succeeded!
Apr 08 14:48:08.712 INFO testinator: Test rust=nightly, features=[unstable] succeeded!
Apr 08 14:48:35.992 INFO testinator: Test rust=stable, features=[bitcoinconsensus] succeeded!
Apr 08 14:48:49.871 INFO testinator: Test rust=nightly, features=[bitcoinconsensus] succeeded!
Apr 08 14:48:55.931 INFO testinator: Test rust=1.29.0, features=[base64] succeeded!
Apr 08 14:49:15.071 INFO testinator: Test rust=stable, features=[secp-recovery,use-serde,base64,secp-lowmemory,rand,bitcoinconsensus] succeeded!
Apr 08 14:49:24.216 INFO testinator: Test rust=nightly, features=[secp-recovery,use-serde,base64,secp-lowmemory,rand,unstable,bitcoinconsensus] succeeded!
Apr 08 14:49:47.253 INFO testinator: Test rust=nightly, features=[] succeeded!
Apr 08 14:50:09.674 INFO testinator: Test rust=1.29.0, features=[secp-lowmemory] succeeded!
Apr 08 14:50:09.675 INFO testinator: Test rust=stable, features=[] succeeded!
Apr 08 14:50:52.175 INFO testinator: Test rust=1.29.0, features=[rand] succeeded!
Apr 08 14:51:43.599 INFO testinator: Test rust=1.29.0, features=[bitcoinconsensus] succeeded!
Apr 08 14:52:32.104 INFO testinator: Test rust=1.29.0, features=[secp-recovery,use-serde,base64,secp-lowmemory,rand,bitcoinconsensus] succeeded!
Apr 08 14:53:13.775 INFO testinator: Test rust=1.29.0, features=[] succeeded!
Apr 08 14:53:18.958 INFO testinator: Fuzzing deserialize_script
Apr 08 14:54:41.116 INFO testinator: Successfully fuzzed deserialize_script
Apr 08 14:54:41.117 INFO testinator: Fuzzing uint128_fuzz
Apr 08 14:55:42.240 INFO testinator: Successfully fuzzed uint128_fuzz
Apr 08 14:55:42.240 INFO testinator: Fuzzing deserialize_amount
Apr 08 14:56:43.108 INFO testinator: Successfully fuzzed deserialize_amount
Apr 08 14:56:43.108 INFO testinator: Fuzzing deserialize_transaction
Apr 08 14:57:45.125 INFO testinator: Successfully fuzzed deserialize_transaction
Apr 08 14:57:45.126 INFO testinator: Fuzzing deser_net_msg
Apr 08 14:58:48.119 INFO testinator: Successfully fuzzed deser_net_msg
Apr 08 14:58:48.119 INFO testinator: Fuzzing deserialize_address
Apr 08 14:59:49.093 INFO testinator: Successfully fuzzed deserialize_address
Apr 08 14:59:49.093 INFO testinator: Fuzzing deserialize_block
Apr 08 15:00:51.086 INFO testinator: Successfully fuzzed deserialize_block
Apr 08 15:00:51.086 INFO testinator: Fuzzing outpoint_string
Apr 08 15:01:52.197 INFO testinator: Successfully fuzzed outpoint_string
Apr 08 15:01:52.197 INFO testinator: Fuzzing deserialize_psbt
Apr 08 15:02:55.212 INFO testinator: Successfully fuzzed deserialize_psbt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm utack
My OCD for fixing yellow lines in the build process.