Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Script::dust_value()'s calculation for non-P2*PKH script_pubkeys #579

Merged
merged 2 commits into from May 6, 2021
Merged

Fix Script::dust_value()'s calculation for non-P2*PKH script_pubkeys #579

merged 2 commits into from May 6, 2021

Commits on May 1, 2021

  1. Fix Script::dust_value()'s calculation for non-P2*PKH script_pubkeys 

    The dust calculations added were only valid for P2WPKH and P2PKH
outputs, and somehow this fact was missed in review, despite the
upstream Core code being linked to and looked at by two reviewers
and the author (me).

Someday I will grow eyeballs, but that day is not today.
    @TheBlueMatt
    TheBlueMatt committed May 1, 2021
    Configuration menu
    Copy the full SHA
    15981c9 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. Drop not-very-useful output dust threshold constants 

    It doesn't really make sense to have a constant for every common
script type's dust limit, instead we should just use the
`Script::dust_value()` function to have users calculate it.
    @TheBlueMatt
    TheBlueMatt committed May 5, 2021
    Configuration menu
    Copy the full SHA
    fc6f23f View commit details
    Browse the repository at this point in the history