Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include proprietary key in deserialized PSBT #577

Merged
merged 2 commits into from Mar 15, 2021
Merged

Include proprietary key in deserialized PSBT #577

merged 2 commits into from Mar 15, 2021

Conversation

RCasatta
Copy link
Collaborator

Fix bug introduced in #471

Proprietary keys in PSBT were not deserialized back

first commit introduce a failing test, second commit fix the test

stevenroose
stevenroose approved these changes Mar 13, 2021
View reviewed changes
Copy link
Collaborator

@stevenroose stevenroose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, thanks! ACK

sgeisler
sgeisler approved these changes Mar 14, 2021
View reviewed changes
Copy link
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 7e25c13

@stevenroose stevenroose merged commit 7df0d14 into rust-bitcoin:master Mar 15, 2021
@dr-orlovsky dr-orlovsky added this to the 0.26.1 milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenroose stevenroose stevenroose approved these changes

@sgeisler sgeisler sgeisler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.26.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RCasatta @stevenroose @sgeisler @dr-orlovsky