New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/error derives 2 #559
Fix/error derives 2 #559
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK b809d83
@sanket1729 thank you for your review; unfortunately had to discard it because of rebasing on CI bugfix from #602. Can you pls re-ACK it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK c0b7def
/// A child number was provided that was out of range | ||
InvalidChildNumber(u32), | ||
/// Error creating a master seed --- for application use | ||
RngError(String), | ||
RngError(String), // TODO: This option seems unused and should be removed, opening a way to make this type copiable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for application use, as mentioned in the doccomment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack c0b7def
This continues (and is based on the work from) #558 and is a part of #555 epic for Error types within rust-bitcoin. This PR is also non-API breaking, but unline #558 depends on PRs in upstream repos:
Once they got merged & a new versions of the crates will be published, CI will not be failing anymore here and PR will be ready for reviews