Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version to 0.26 #533

Merged
merged 1 commit into from Jan 14, 2021
Merged

Conversation

apoelstra
Copy link
Member

No description provided.

@dr-orlovsky
Copy link
Collaborator

dr-orlovsky commented Dec 21, 2020

Discussed potential PRs pending for this release (from IRC):

@apoelstra
Copy link
Member Author

#498 I don't think we ever came to a conclusion on the blanket impl of that trait? I'd like an ack from @stevenroose

I'll take a look at everything else today.

@apoelstra
Copy link
Member Author

#524 was pretty controversial, I don't think we're gonna get it in.

@dr-orlovsky
Copy link
Collaborator

#498 I don't think we ever came to a conclusion on the blanket impl of that trait? I'd like an ack from @stevenroose

Can pls @stevenroose clarify the situation? From what I am getting from his comments is that he is neither pro or against and asks others to decide

@apoelstra
Copy link
Member Author

Rebased. We should be good to go.

sanket1729
sanket1729 previously approved these changes Jan 12, 2021
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack d22f365 . Awaiting CI

Copy link
Collaborator

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one of the things which were missed

- Add [Taproot Tagged Hashes](https://github.com/rust-bitcoin/rust-bitcoin/pull/259)
- Add [`message::MAX_INV_SIZE` constant](https://github.com/rust-bitcoin/rust-bitcoin/pull/516)
- impl [`ToSocketAddrs` for network addresses](https://github.com/rust-bitcoin/rust-bitcoin/pull/514)
- Add [new global fields to PSBT](https://github.com/rust-bitcoin/rust-bitcoin/pull/499)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Add [new global fields to PSBT](https://github.com/rust-bitcoin/rust-bitcoin/pull/499)
- Add [new global fields to PSBT](https://github.com/rust-bitcoin/rust-bitcoin/pull/499)
- [Serde serialization of PSBT data](https://github.com/rust-bitcoin/rust-bitcoin/pull/497)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 010068b

@apoelstra apoelstra merged commit c9c2e45 into rust-bitcoin:master Jan 14, 2021
@apoelstra apoelstra deleted the 2020-12--0.26.0 branch January 14, 2021 17:12
yancyribbens pushed a commit to yancyribbens/rust-bitcoin that referenced this pull request Mar 23, 2024
…cs for proper use of std and no-std features

2f84d32 Add README build docs for std and no-std (Steve Myers)
d1c71e3 Add build error if both std and no-std features disabled (Steve Myers)

Pull request description:

  Building this crate requires the std and/or no-std features be enabled. This PR documents this build constraint in the README and gives an error is anyone tries to build without enabling one or both of these features.

  See discussion in rust-bitcoin#533.

ACKs for top commit:
  Kixunil:
    ACK 2f84d32
  apoelstra:
    ACK 2f84d32

Tree-SHA512: b25606739caa4f3a586f55cf774aa824a836f17fd19412087243d6d0b62f46900031c39d8f8bce1d5d42857b2dd0c9a5d6d6e7a559abd3aad250251f77dd9ef5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants