chore: format and standardize all markdowns files #2726
Merged
+55
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to the github flavor (https://github.github.com/gfm/)
github-actions
bot
added
C-bitcoin
storopoli
commented
Apr 27, 2024
Comment on lines
+6
to
+8
| - `*_hex`: consensus encoded types represented as hex strings | ||
| - `*_ser`: consensus encoded types represented as binary data | ||
| - `*_bincode`: types serialized with `serde` as bincode |
There was a problem hiding this comment.
Opinionated: this should be highlighted as code
storopoli
commented
Apr 27, 2024
Comment on lines
+10
to
+11
| We consensus deserialize, `serde` serialize, then check against the expected data | ||
| to verify no `serde` regressions have been introduced. |
There was a problem hiding this comment.
We already highlight "serde" as inline code, so this is standardizing it.
Pull Request Test Coverage Report for Build 8858884788Details
💛 - Coveralls |
storopoli
commented
Apr 27, 2024
|
|
||
| # Fuzzing with weak cryptography | ||
| ## Fuzzing with weak cryptography |
There was a problem hiding this comment.
A markdown file should have only one H1.
storopoli
commented
Apr 27, 2024
Comment on lines
+9
to
+13
| ```bash | ||
| cargo update -p serde --precise 1.0.156 | ||
| cargo update -p regex --precise 1.7.3 | ||
| cargo update -p chrono --precise 0.4.24 | ||
| ``` |
There was a problem hiding this comment.
Opinionated: this should be a fenced block for nice syntax highlighting
storopoli
commented
Apr 27, 2024
|
|
||
| The `std::io` module is not exposed in `no-std` Rust so building `no-std` applications which require | ||
| reading and writing objects via standard traits is not generally possible. Thus, this library exists | ||
| to export a minmal version of `std::io`'s traits which we use in `rust-bitcoin` so that we can | ||
| to export a minimal version of `std::io`'s traits which we use in `rust-bitcoin` so that we can |
storopoli
commented
Apr 27, 2024
| @@ -23,7 +23,7 @@ Rust Logo is licensed under CC-BY, which allows reuse and modifications for any | |||
|
|
|||
| ## Acknowledgements | |||
|
|
|||
| Acknowledgement for the runners up in this PR: https://github.com/rust-bitcoin/rust-bitcoin/pull/891#issuecomment-1074476858 | |||
| Acknowledgement for the runners up in this PR: <https://github.com/rust-bitcoin/rust-bitcoin/pull/891#issuecomment-1074476858> | |||
There was a problem hiding this comment.
Automatic formatted by my linter.
We can revert if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to the github flavor
(https://github.github.com/gfm/)