Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitcoin: Upgrade base64 dependency #2721

Merged
merged 1 commit into from Apr 28, 2024

Conversation

tcharding
Copy link
Member

Upgrade to the latest release of base64. Version 0.22.0 came out about 2 months ago.

No code changes needed and from the release notes it doesn't look like anything that will effect us too much.

https://github.com/marshallpierce/rust-base64/blob/master/RELEASE-NOTES.md

The base64 crate is part of our public API so this is a breaking change.

Upgrade to the latest release of `base64`. Version 0.22.0 came out
about 2 months ago.

No code changes needed and from the release notes it doesn't look like
anything that will effect us too much.

https://github.com/marshallpierce/rust-base64/blob/master/RELEASE-NOTES.md
@tcharding tcharding added the API break This PR requires a version bump for the next release label Apr 25, 2024
@github-actions github-actions bot added the C-bitcoin PRs modifying the bitcoin crate label Apr 25, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8840776743

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.131%

Totals Coverage Status
Change from base Build 8832141948: 0.0%
Covered Lines: 19195
Relevant Lines: 23090

💛 - Coveralls

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e34e2fd

Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e34e2fd

Copy link
Member

@clarkmoody clarkmoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e34e2fd

@apoelstra apoelstra merged commit ed11bf5 into rust-bitcoin:master Apr 28, 2024
168 checks passed
@tcharding
Copy link
Member Author

@clarkmoody! Good to see you, thanks for the reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API break This PR requires a version bump for the next release C-bitcoin PRs modifying the bitcoin crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants