psbt: Use macro to hash instead of relying on Hash trait
#2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a private function that makes use of the `Hash` trait to generically hash map entries. This usage makes patching the `hashes` module difficult. We can achieve the same thing by using a macro and passing in the concrete type. This is an internal change, no effect on logic or public API.
Pull Request Test Coverage Report for Build 8825286212Details
💛 - Coveralls |
|
Very interesting. I guess this is an actual use of "being generic over a hash". I suppose we could have used this pattern in rust-miniscript but I don't think it ever occurred to us that these different hashtypes share a trait, bacues it's a bit of a weird thing. concept ACK convering this to a macro (and, when we remove the |
apoelstra
approved these changes
Apr 25, 2024
tcharding
changed the title
Hash trait
|
Changed PR name to make searching easier because this is related to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a private function that makes use of the
Hashtrait to generically hash map entries. This usage makes patching thehashesmodule difficult. We can achieve the same thing by using a macro and passing in the concrete type.This is an internal change, no effect on logic or public API.