Improve hashes trait method usage
#2714
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we use the `Hash` trait in a bunch of places to call `all_zeros`. We are attempting to improve the `hashes` API and this usage is both unnecessary and also hindering that effort. Use the concrete type (e.g. `BlockHash`) instead of calling through the trait method. Refactor only, no logic changes.
Pull Request Test Coverage Report for Build 8855222593Details
💛 - Coveralls |
tcharding
force-pushed
the
04-25-stop-using-hashes-by-name
branch
from
2a2b57f
to
a3a7389
Compare
apoelstra
reviewed
Apr 25, 2024
| @@ -308,7 +308,7 @@ mod test { | |||
|
|
|||
| use hex::{test_hex_unwrap as hex, FromHex}; | |||
|
|
|||
| use super::{AddrV2, AddrV2Message, Address}; | |||
| use super::*; | |||
There was a problem hiding this comment.
In 9c47158:
There are still more explicit imports you need to drop if you add super::*.
There was a problem hiding this comment.
Bother, thanks - I'll re-look.
There was a problem hiding this comment.
You might need to compile with nightly, and possibly nightly from a week ago, because I believe they just reverted a bunch of the "redundant import" lints due to mass protests.
Clean up the test imports in the `p2p` module: - Use `use super::*` as is conventional. - Use `sha256d::Hash` as is conventional. Refactor, no logic changes.
tcharding
force-pushed
the
04-25-stop-using-hashes-by-name
branch
from
a3a7389
to
621ff28
Compare
|
Force push is the PR done properly this time:
|
Bringing traits into scope risks naming conflicts for no real reason because we can import traits using `as _`. Also, in `hashes` we always use `as _` so `bitcoin` and `hashes` are currently non-uniform. Use as-underscore when importing the `Hash` and `HashEngine` traits. Refactor, no logic changes.
tcharding
force-pushed
the
04-25-stop-using-hashes-by-name
branch
from
621ff28
to
9e924cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done as part of the ongoing work to improve the
hashesAPI.all_zerosinstead of the trait method.p2punit test imports (preparation for next patch)as _when importingHashandHashEngineThis whole PR is refactor only, no logic changes.