Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hashes: Do not import str #2662

Merged
merged 1 commit into from May 4, 2024
Merged

hashes: Do not import str #2662

merged 1 commit into from May 4, 2024
+8 −12

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Apr 5, 2024 •
edited

Depending on things being in scope for macros to use is bad form, using the fully qualified path is the correct way.

Do not import str instead use the fully qualified path to the core re-export.

Use fully qualified path instead.

@github-actions github-actions bot added the C-hashes PRs modifying the hashes crate label Apr 5, 2024
apoelstra
apoelstra approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 984e1a2 not API-visible, fine to do alongside the release

@tcharding tcharding force-pushed the 04-04-hashes-do-not-import-str branch from 984e1a2 to 0ae750b Compare April 5, 2024 19:49
@tcharding
hashes: Do not import str
71bb862 
Depending on things being in scope for macros to use is bad form,
using the fully qualified path is the correct way.

Do not import `str` instead use the fully qualified path to the `core`
re-export.

Use fully qualified instead.
@tcharding tcharding force-pushed the 04-04-hashes-do-not-import-str branch from 0ae750b to 71bb862 Compare April 5, 2024 19:49
@tcharding tcharding marked this pull request as ready for review April 5, 2024 19:49
@tcharding
Copy link
Member Author

tcharding commented Apr 5, 2024 •
edited

This PR (combined with #2666) demonstrates the new branching strategy explained here: #2657 (comment)

This PR targets master and is the continuation of normal development, never to be released as part of the 0.32.x releases.

@coveralls
Copy link

coveralls commented Apr 5, 2024 •
edited

Pull Request Test Coverage Report for Build 8574970411

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.117%
Totals Coverage Status
Change from base Build 8573430294: 0.0%
Covered Lines: 19186
Relevant Lines: 23083
💛 - Coveralls

@tcharding tcharding mentioned this pull request Apr 5, 2024
Closed
@tcharding
Copy link
Member Author

tcharding commented May 3, 2024 •
edited

Candidate for merge now please, acked and open for over two weeks with no comments or nacks.

apoelstra
apoelstra approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 71bb862 trivial rebase

sanket1729
sanket1729 approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 71bb862

@apoelstra apoelstra merged commit 343c770 into rust-bitcoin:master May 4, 2024
168 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@sanket1729 sanket1729 sanket1729 approved these changes

Assignees
No one assigned
Labels
C-hashes PRs modifying the hashes crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tcharding @coveralls @apoelstra @sanket1729