Some additional inspectors on Script and Witness #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8522463247Details
💛 - Coveralls |
stevenroose
force-pushed
the
script-inspectors
branch
from
967cbf5
to
ac4db63
Compare
tcharding
approved these changes
Apr 3, 2024
Comment on lines
+412
to
+418
| /// Get the taproot control block following BIP341 rules. | ||
| /// | ||
| /// This does not guarantee that this represents a P2TR [`Witness`]. It | ||
| /// merely gets the last or second to last element depending on the first | ||
| /// byte of the last element being equal to 0x50. See | ||
| /// [Script::is_p2tr](crate::blockdata::script::Script::is_p2tr) to | ||
| /// check whether this is actually a Taproot witness. |
There was a problem hiding this comment.
In case you want it, a bunch of these docs could be cleaned up to look like this:
/// Gets the taproot control block following BIP341 rules.
///
/// This does not guarantee that this represents a P2TR [`Witness`]. It merely gets the last or
/// second to last element depending on the first byte of the last element being equal to 0x50.
///
/// See [`Script::is_p2tr`] to check whether this is actually a Taproot witness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundled these because they are very similar. Got a bunch of larger changes coming up based on these. I've been using these for a while for TXHASH work.