move all_zeroes & from_byte_array to inherents & make them const.

[15IITian]

Made these functions const fn & move them from the Hash trait to hash_type & hash_newtype macros

fix #2377

[coveralls]

Pull Request Test Coverage Report for Build 8583563910

Details

• 29 of 30 (96.67%) changed or added relevant lines in 9 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.02%) to 83.137%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
bitcoin/src/blockdata/constants.rs	5	6	83.33%

Totals
Change from base Build 8573430294:	0.02%
Covered Lines:	19188
Relevant Lines:	23080

---

💛 - Coveralls

[apoelstra]

1d6373d looks good to me other than the grammar thing.

Also, the CI failure is minor but real -- please remove the now-unused Hash import from the example.

[15IITian]

https://github.com/rust-bitcoin/rust-bitcoin/actions/runs/8490482071/job/23261584927?pr=2641

Can you please tell how to solve this error.

[15IITian]

Recently noticed -> our code is not formatted according to rust fmt tool (cargo fmt).

[tcharding]

Thanks for the PR, this is not a refactor, its an API breaking change because it removes functions from a public trait. I always link contributors to https://chris.beams.io/posts/git-commit/ (also mentioned in CONTRIBUTING.md). If a dev describes why we should have a change, and what the change is then it clarifies a bunch of things, including that:

• dev understands fully the change (the why and the what)
• reviewer can understand the context

I don't think you would have written "refactor" after writing a why/what PR description for the changes in this PR :)

[tcharding]

Converting to draft because we are in a feature freeze right now, this needs to wait until rust-bitcoin 0.32.0 is out.

[15IITian]

this is not a refactor, its an API breaking change because it removes functions from a public trait

Well ,I agree that it is more often a api breaking change but while writting conventional commit ->I could'nt find more relevant tag than 'refactor' -> A code change that neither fixes a bug nor adds a feature :)

I always link contributors to https://chris.beams.io/posts/git-commit/ (also mentioned in CONTRIBUTING.md)

👍

[tcharding]

"Refactor" is a well defined term:

In computer programming and software design, code refactoring is the process of restructuring existing computer code—changing the factoring—without changing its external behavior.

ref: https://en.wikipedia.org/wiki/Code_refactoring.

We don't enforce any particular format of git brief messages, so there is no requirement to put any sort of tag at the start of the message. Just something simple like "Use inherent functions instead of trait methods" would be fine.

Thanks

[tcharding]

Feature freeze is over man, you are free to push this up if you want to.