Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitcoin: Depend on and export hex-conservative #2620

Merged
merged 1 commit into from May 4, 2024

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Mar 20, 2024

When we did the rust-bitcoin v0.30.0 release we had not yet released the hex-conservative crate so we forced users to reach into bitcoin-internals to get at hex stuff e.g., DisplayHex.

To ease the upgrade path for any remaining upgraders add a dependency on the now released hex-conservative crate and re-export it from the crate root as hex (bit late I know, sorry).

Idea came from: #2482 (comment)

We should have done this soon as we released hex-conservative.

When we did the `rust-bitcoin v0.30.0` release we had not yet released
the `hex-conservative` crate so we forced users to reach into
`bitcoin-internals` to get at hex stuff e.g., `DisplayHex`.

To ease the upgrade path for any remaining upgraders add a dependency
on the now released `hex-conservative` crate and re-export it from the
crate root as `hex` (bit late I know, sorry).
@tcharding
Copy link
Member Author

CI failures include:

  • clippy
  • pinning

@apoelstra
Copy link
Member

Innnteresting. Maybe we need to pin stable same as we pin nightly. (IMO we can just drop beta, I'm not even sure what winds up on that channel but I can't imagine it's meaningfully different from nightly.)

@apoelstra
Copy link
Member

I think a new stable was released last night https://lwn.net/Articles/966205/

@tcharding
Copy link
Member Author

Maybe we need to pin stable same as we pin nightly

Isn't the problem that back then we were running clippy with stable toolchain, which we don't do now so we can just ignore these warnings?

@apoelstra
Copy link
Member

Oh, derp, I did not realize this was a backport. Yes, in that case it's just because we used to be running clippy on stable.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 8273b80 -- tested cargo test at least

@apoelstra
Copy link
Member

It's kinda a pain in the ass to test 0.30.0, because we have the unstable docsrs feature so --all-features doesn't work, we don't have the committed lockfiles so I need to generate my own, etc.

But this is a short, obviously-correct diff so I just did some basic checks.

@tcharding
Copy link
Member Author

Gentle bump, when you get around to it please.

@apoelstra
Copy link
Member

Cool, 2 weeks (actually much longer) and no other comments. Will merge.

@apoelstra apoelstra merged commit e376e90 into rust-bitcoin:0.30.x May 4, 2024
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants