New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitcoin: Depend on and export hex-conservative #2620
Conversation
When we did the `rust-bitcoin v0.30.0` release we had not yet released the `hex-conservative` crate so we forced users to reach into `bitcoin-internals` to get at hex stuff e.g., `DisplayHex`. To ease the upgrade path for any remaining upgraders add a dependency on the now released `hex-conservative` crate and re-export it from the crate root as `hex` (bit late I know, sorry).
6139e24
to
8273b80
Compare
CI failures include:
|
Innnteresting. Maybe we need to pin |
I think a new stable was released last night https://lwn.net/Articles/966205/ |
Isn't the problem that back then we were running clippy with |
Oh, derp, I did not realize this was a backport. Yes, in that case it's just because we used to be running clippy on stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 8273b80 -- tested cargo test
at least
It's kinda a pain in the ass to test 0.30.0, because we have the unstable But this is a short, obviously-correct diff so I just did some basic checks. |
Gentle bump, when you get around to it please. |
Cool, 2 weeks (actually much longer) and no other comments. Will merge. |
When we did the
rust-bitcoin v0.30.0
release we had not yet released thehex-conservative
crate so we forced users to reach intobitcoin-internals
to get at hex stuff e.g.,DisplayHex
.To ease the upgrade path for any remaining upgraders add a dependency on the now released
hex-conservative
crate and re-export it from the crate root ashex
(bit late I know, sorry).Idea came from: #2482 (comment)
We should have done this soon as we released
hex-conservative
.