Move test_data/* to tests/data
#1347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK 374008b |
|
Remember to update the exclude field in |
tcharding
force-pushed
the
10-22-move-test_data
branch
from
374008b
to
0826b96
Compare
Ah yes, thanks man. |
|
Force pushed fix to exclude |
In preparation for adding integration tests in the standard Rust `tests/` directroy; move the contents of `test_data` to `tests/data`.
tcharding
force-pushed
the
10-22-move-test_data
branch
from
0826b96
to
ffad4c6
Compare
|
Oops, sorry I merged #935 which already contained this commit. We can use this PR to iterate if needed, otherwise, we can close this. |
|
I'm ok with closing. |
|
My bad, I'll double check its all merged correctly, I made things worse trying to make them easier :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for adding integration tests in the standard Rust
tests/directroy; move the contents oftest_datatotests/data.This was originally part of #724 but that is proving to take an eon to merge so lets put this patch in first. Can then be used by #935 (cc @DanGould).