Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update finalize API #1151

Merged
merged 4 commits into from Aug 1, 2022
Merged

Update finalize API #1151

merged 4 commits into from Aug 1, 2022

Commits on Jul 29, 2022

  1. Return EmptyTree instead of OverCompleteTree when there are no scripts 

    to add
    @sanket1729
    sanket1729 committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    5813ec7 View commit details
    Browse the repository at this point in the history

  2. Update TaprootBuilder::finalize 

    This commit does two things:
1) BUG FIX: We should have checked that the length of the branch is 1
before computing the spend_info on it. This was introduced in rust-bitcoin#936, but
slipped past my review :(
2) Update the return type to return the consumed `self` value. This
function can only error when there the tree building is not complete.
Returning TaprootBuilderError causes issues in downstream projects that
need to deal with error cases which cannot happen in this function
    @sanket1729
    sanket1729 committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    0b88051 View commit details
    Browse the repository at this point in the history

  3. Add breaking test that allowed incomplete builders to be created

    @sanket1729
    sanket1729 committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    aaadd25 View commit details
    Browse the repository at this point in the history

  4. Rename is_finalized to is_finalizable 

    I really liked the is_complete naming, but that was changed earlier in b0f3992
Was also suggested by Andrew rust-bitcoin#929 (comment)
    @sanket1729
    sanket1729 committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    870ad59 View commit details
    Browse the repository at this point in the history