Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement human-readable serde for Witness #1068

Merged
merged 6 commits into from Jul 18, 2022

Commits on Jul 11, 2022

  1. Add whitespace between functions

    As is customary leave a line of white space between functions.
    tcharding committed Jul 11, 2022
    Copy the full SHA
    ac55b10 View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary whitespace

    No need for a line of whitespace immediately starting an impl block.
    tcharding committed Jul 11, 2022
    Copy the full SHA
    e23d3a8 View commit details
    Browse the repository at this point in the history
  3. witness: Refactor import statements

    Re-order the import statements in `witness` module to separate `crate`
    imports from dependency imports.
    tcharding committed Jul 11, 2022
    Copy the full SHA
    b409ae7 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. Witness serde: test binary encoding to be backward-compatible

    This also removes tests for JSON backward-compatible encoding. Human-readable 
    encoding will be changed in the next commit and this will break backward 
    compatibility, thus that part of the test is removed.
    dr-orlovsky authored and tcharding committed Jul 12, 2022
    Copy the full SHA
    93b66c5 View commit details
    Browse the repository at this point in the history
  2. Witness human-readable serde

    Previous implementations of Witness (and Vec<Vec<u8>>) serde serialization
    didn't support human-readable representations. This resulted in long unreadable
    JSON/YAML byte arrays, which were especially ugly when pretty-printed (a line
    per each byte).
    
    Co-authored-by: Tobin C. Harding <me@tobin.cc>
    dr-orlovsky and tcharding committed Jul 12, 2022
    Copy the full SHA
    68577df View commit details
    Browse the repository at this point in the history
  3. Witness human-readable serde test

    dr-orlovsky authored and tcharding committed Jul 12, 2022
    Copy the full SHA
    a1df62a View commit details
    Browse the repository at this point in the history