Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect argument passed to Error::InvalidSegwitV0ProgramLength and add test #1039

Merged
merged 1 commit into from Jun 15, 2022
Merged

Fix incorrect argument passed to Error::InvalidSegwitV0ProgramLength and add test #1039

merged 1 commit into from Jun 15, 2022

Conversation

Eunoia1729
Copy link
Contributor

@Eunoia1729 Eunoia1729 commented Jun 5, 2022 •
edited

See also: #995, #1038

@Eunoia1729 Eunoia1729 changed the title test: invalid script len test for Address::from_script Fix incorrect argument passed to Error::InvalidSegwitV0ProgramLength and add test Jun 11, 2022
sanket1729
sanket1729 approved these changes Jun 11, 2022
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 24fdb53. Nice catch

@Eunoia1729 Eunoia1729 marked this pull request as ready for review June 11, 2022 01:42
apoelstra
apoelstra approved these changes Jun 11, 2022
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 24fdb53

tcharding
tcharding approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 24fdb53

@apoelstra apoelstra merged commit d363cd2 into rust-bitcoin:master Jun 15, 2022
ChallengeDev210 pushed a commit to ChallengeDev210/rust-bitcoin that referenced this pull request Aug 1, 2022
@apoelstra
Merge rust-bitcoin/rust-bitcoin#1039: Fix incorrect argument passed t…
5e7bfd0 
…o Error::InvalidSegwitV0ProgramLength and add test

24fdb53 Fix incorrect argument passed to Error::InvalidSegwitV0ProgramLength (eunoia_1729)

Pull request description:

  See also: #995, #1038

ACKs for top commit:
  sanket1729:
    utACK 24fdb53. Nice catch
  apoelstra:
    ACK 24fdb53
  tcharding:
    ACK 24fdb53

Tree-SHA512: ced78b69054ec81431399a853291c7bad5b1a49d6683b1ac153a0f1449935bb5d75a31e3d86160602064530959a2ddc3c59a2a2ca268252c42a6805253ead9d0
@Kixunil Kixunil added the bug label Aug 1, 2022
@Kixunil Kixunil added this to the 0.29.0 milestone Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@sanket1729 sanket1729 sanket1729 approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.29.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Eunoia1729 @apoelstra @sanket1729 @tcharding @Kixunil